Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implement HasInstance() for OCI providers #7154

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: implement HasInstance() for OCI providers #7154

merged 1 commit into from
Aug 19, 2024

Conversation

alfredkrohmer
Copy link
Contributor

This implements HasInstance() for the OCI instance pool and node pool providers.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Citing #5054 (comment):

...original intent of determining the deleted nodes was incorrect, which led to the issues reported by other users. The nodes tainted with ToBeDeleted were misidentified as Deleted instead of Ready/Unready, which caused a miscalculation of the node being included as Upcoming. This caused problems described in #3949 and #4456.

Which issue(s) this PR fixes:

Fixes #4456

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@alfredkrohmer
fix: implement HasInstance() for OCI providers
db59e7a 
This implements HasInstance() for the OCI instance pool and node pool providers.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/cluster-autoscaler labels Aug 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jlamillan August 12, 2024 14:39
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n August 12, 2024 14:39
@k8s-ci-robot k8s-ci-robot added area/provider/oci Issues or PRs related to oci provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @alfredkrohmer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2024
@jlamillan
Copy link
Contributor

This looks good to me. @trungng92 does it look good to you?

@trungng92
Copy link
Contributor

This looks good to me. @trungng92 does it look good to you?

Yep. Change looks good with me too. We are going to repro the original issue mentioned and verify the fix.

jlamillan
jlamillan approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jlamillan jlamillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfredkrohmer, jlamillan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1f89ff9 into kubernetes:master Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlamillan jlamillan jlamillan approved these changes

@x13n x13n Awaiting requested review from x13n

Assignees

@jlamillan jlamillan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/oci Issues or PRs related to oci provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA fails to scale-up or cancel in-progress scale down when there are un-schedulable pods
4 participants
@alfredkrohmer @k8s-ci-robot @jlamillan @trungng92